Apply formatter to all GN files. #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no CI hook to check formatting of .gn and .gni files in the buildroot. Applies the formatter to all files with no change in behavior. The same actions were done on the engine and all files were correctly formatted already which proves the auto-formatter is working there.
|
This was an annoyance of working on editing buildroot files using an editor that formats on save. You'd end up changing unrelated files. I'm weary of adding more CI to this repo. Instead, we can just wait it out till the buildroot is gone. cc @matanlurey |
zanderso
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no CI hook to check formatting of .gn and .gni files in the buildroot.
Applies the formatter to all files with no change in behavior.
The same actions were done on the engine and all files were correctly formatted already which proves the auto-formatter is working there.