Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: g-code preview alternative controls #969

Merged

Conversation

pedrolamas
Copy link
Member

@pedrolamas pedrolamas commented Nov 29, 2022

Moves the G-Code Previewer controls to inside the SVG container.

Dark

image

Light

image

Fixes #926

Signed-off-by: Pedro Lamas [email protected]

@pedrolamas pedrolamas force-pushed the pedrolamas/gcode-preview-controls branch from 88aa4b6 to a82dac6 Compare November 30, 2022 14:19
@pedrolamas pedrolamas force-pushed the pedrolamas/gcode-preview-controls branch from a82dac6 to 502d560 Compare November 30, 2022 15:43
@pedrolamas pedrolamas added the UI - QoL Improvements to the UI label Dec 1, 2022
@pedrolamas pedrolamas added this to the 1.22 milestone Dec 1, 2022
@pedrolamas pedrolamas marked this pull request as ready for review December 1, 2022 17:16
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I tested the UX on mobile and it seems fine to me (not too small).
I did however also notice that #898 didn't actually fix the gcode preview behavior, so I will need to revisit that on the weekend..

@pedrolamas pedrolamas merged commit 846f5f9 into fluidd-core:develop Dec 2, 2022
@pedrolamas pedrolamas deleted the pedrolamas/gcode-preview-controls branch December 2, 2022 20:48
koriwi pushed a commit to koriwi/fluidd that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI - QoL Improvements to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follow progress on gcode preview be displayed on header bar
2 participants