-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user/device specific layouts #878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathis Mensing <[email protected]>
matmen
added
FR - Enhancement
New feature or request
UI - QoL
Improvements to the UI
UI - Change
All matters related to a significant change in the UI
labels
Sep 26, 2022
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
…actions Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
pedrolamas
reviewed
Sep 28, 2022
pedrolamas
reviewed
Sep 28, 2022
pedrolamas
reviewed
Sep 28, 2022
pedrolamas
requested changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine, but I think that getter should be renamed to make clear it returns the layout name and not the actual layout objects!
Co-authored-by: Pedro Lamas <[email protected]>
Co-authored-by: Pedro Lamas <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
pedrolamas
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FR - Enhancement
New feature or request
UI - Change
All matters related to a significant change in the UI
UI - QoL
Improvements to the UI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates user and device specific layouts on layout change (based on concatenation of
dashboard-{user}-{device-size}
, clones currentdashboard
if no custom one exists yet).Allows the overriding of the default layout for new users (or other devices), which can also be reset to the initial state.
Not 100% sure about the placement and usage of header buttons here, but it's what was there before:
Closes #370
Closes #410