Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user/device specific layouts #878

Merged
merged 9 commits into from
Sep 29, 2022

Conversation

matmen
Copy link
Member

@matmen matmen commented Sep 26, 2022

Creates user and device specific layouts on layout change (based on concatenation of dashboard-{user}-{device-size}, clones current dashboard if no custom one exists yet).

Allows the overriding of the default layout for new users (or other devices), which can also be reset to the initial state.
Not 100% sure about the placement and usage of header buttons here, but it's what was there before:
image

Closes #370
Closes #410

@matmen matmen added FR - Enhancement New feature or request UI - QoL Improvements to the UI UI - Change All matters related to a significant change in the UI labels Sep 26, 2022
@matmen matmen added this to the 1.21 milestone Sep 26, 2022
@matmen matmen marked this pull request as ready for review September 27, 2022 21:03
src/views/Dashboard.vue Outdated Show resolved Hide resolved
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine, but I think that getter should be renamed to make clear it returns the layout name and not the actual layout objects!

@matmen matmen merged commit 9f198d6 into fluidd-core:develop Sep 29, 2022
@matmen matmen deleted the feat/multiple-layouts branch September 29, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request UI - Change All matters related to a significant change in the UI UI - QoL Improvements to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: User specific layouts device specific layout
2 participants