fix: Correct SVG transformations in GCode Preview #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a printer is not configured to have a (0,0) (xmin, ymin) coordinate, the GCode preview currently does not show up like in the picture below. For example, my printer's x goes from -113 to +113 and y from -74 to +74.
I fixed two issues with the SVG generation:
viewBox
are the width & height of the image, not the +x and +y values.Now, the preview shows up:
Signed-off-by: Ryan Adolf [email protected]