Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check Bed_Mesh Support #801

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

kerbilg
Copy link
Member

@kerbilg kerbilg commented Jul 28, 2022

Only shows the bed_mesh card if bed_mesh is available and klipper is ready (important for the dashboard card).

Signed-off-by: Kerim Bilgic [email protected]

Signed-off-by: Kerim Bilgic <[email protected]>
matmen
matmen previously approved these changes Jul 28, 2022
@pedrolamas
Copy link
Member

I haven't tested these yet, but I wonder if these would be better suited directly on Dashboard.vue, on the filtered method?

@matmen
Copy link
Member

matmen commented Jul 28, 2022

True! I forgot about the filtered method..

@kerbilg
Copy link
Member Author

kerbilg commented Jul 28, 2022

The only difference is, that the bed_mesh card will be showed up in layout mode. But this is also the case with other components, so it's another bug.

Signed-off-by: Kerim Bilgic <[email protected]>
@pedrolamas pedrolamas merged commit a38592c into fluidd-core:develop Jul 29, 2022
@pedrolamas pedrolamas added the GH - Bug Something isn't working label Jul 29, 2022
@pedrolamas pedrolamas added this to the 1.19.1 milestone Jul 29, 2022
@kerbilg kerbilg deleted the dashboard-bedmesh branch August 8, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants