Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Exclude Objects #754

Merged
merged 40 commits into from
Jul 10, 2022
Merged

feat: Exclude Objects #754

merged 40 commits into from
Jul 10, 2022

Conversation

matmen
Copy link
Member

@matmen matmen commented Jul 8, 2022 •
edited
Loading

Closes #359
Credits and big thanks to @troy-jacobson and @kageurufu for doing most of the work here!

Using the Gcode viewer to cancel objects:
image
image
image
image

Alternatively using the cancel button at the top of the Gcode viewer:
image

troy-jacobson and others added 24 commits July 8, 2022 20:48
@troy-jacobson @matmen
Initial hack at cancel object UI
aa98f75
@troy-jacobson @matmen
Cleanup
a3bf1ce
@troy-jacobson @matmen
Refactor out of gcode preview
5656b4b
@troy-jacobson @matmen
Refactoring snapshot
6c7bdde
@troy-jacobson @matmen
Refactoring snapshot
4fb0587
@troy-jacobson @matmen
Nicer UI with list reset
70243ea
@troy-jacobson @matmen
Cleanup
9d9adbd
@troy-jacobson @matmen
Cleanup
19a2d13
@troy-jacobson @matmen
Adding new widget to git
258bf35
@troy-jacobson @matmen
parser cleanup
cfeb15c
@troy-jacobson @matmen
Using preprocessed gcode with markers already inserted
788d2e7
@troy-jacobson @matmen
get_status() and outline support from klipper
ccfad3d
@troy-jacobson @matmen
Working implementation using klipper get_status()
6c53657
@troy-jacobson @matmen
Typo fix
f445dcc
@matmen
Add current object tracking
b5e4c30 
Use native types instead of double-JSON for serialization
@troy-jacobson @matmen
hardening and other cleanup tasks
4903108
@matmen
Fix types
61619f5
@matmen
fix: apply eslint fixes
4bc1a97 
Signed-off-by: Mathis Mensing <[email protected]>
@matmen
chore: clean up code
03d4bc8 
Signed-off-by: Mathis Mensing <[email protected]>
@matmen
style: adjust styling for better visibility and intuition
780e6a3 
Signed-off-by: Mathis Mensing <[email protected]>
@matmen
fix: don't open modal if part is already excluded
cc87239 
Signed-off-by: Mathis Mensing <[email protected]>
@matmen
style: switch to cancel icon with larger hitbox
b172fb4 
Signed-off-by: Mathis Mensing <[email protected]>
@matmen
feat(i18n): add exclude object specific message
70283e9 
Signed-off-by: Mathis Mensing <[email protected]>
@matmen
feat: add exclude objects modal/dialog
30993dd 
Signed-off-by: Mathis Mensing <[email protected]>
@matmen matmen added the FR - Enhancement New feature or request label Jul 8, 2022
@matmen matmen added this to the 1.19 milestone Jul 8, 2022
@matmen matmen marked this pull request as ready for review July 8, 2022 22:15
@matmen matmen requested a review from pedrolamas July 8, 2022 22:15
matmen and others added 2 commits July 9, 2022 09:51
@matmen matmen requested a review from pedrolamas July 9, 2022 07:54
@matmen matmen mentioned this pull request Jul 9, 2022
Merged
4 tasks
@matmen
fix: modal max width
2c21cb3 
Signed-off-by: Mathis Mensing <[email protected]>
pedrolamas
pedrolamas requested changes Jul 9, 2022
View reviewed changes
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something feels off about this dialog!
image

src/components/widgets/gcode-preview/GcodePreviewCard.vue Outdated Show resolved Hide resolved
@matmen
Copy link
Member Author

matmen commented Jul 9, 2022

Something feels off about this dialog!

I agree, it doesn't look very great, but I'm not sure how else to style it. If you have any suggestions please let me know ;)
Maybe dynamic width of the dialog as well as having a fixed size for the actions column would be enough here, I'll need to try that

@pedrolamas
Copy link
Member

If you have any suggestions please let me know

is the issue horizontal overflow? We could just set it to show "..." (and add a tooltip if you think it's worth it) in that case and revert the window size changes, no?

@matmen
Copy link
Member Author

matmen commented Jul 9, 2022

is the issue horizontal overflow? We could just set it to show "..." (and add a tooltip if you think it's worth it) in that case and revert the window size changes, no?

Yep, that's exactly the issue. If you want to take a shot at it feel free to, my brain can't figure out how to use CSS properly right now 🤣

@matmen matmen requested a review from pedrolamas July 9, 2022 21:03
@pedrolamas
Copy link
Member

Just tested the latest and feature wise everything seems to be working fine now! 🙂

@matmen matmen merged commit 03ca3ab into fluidd-core:develop Jul 10, 2022
@matmen matmen deleted the feat/cancel-object branch July 10, 2022 08:22
@pedrolamas pedrolamas mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrolamas pedrolamas pedrolamas approved these changes

Assignees
No one assigned
Labels
FR - Enhancement New feature or request
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.

Exclude Region
4 participants
@matmen @kageurufu @pedrolamas @troy-jacobson