-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: device power toggle in top navigation #739
Conversation
Signed-off-by: Mathis Mensing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!! 🙂
I've suggested an alternative translation for the tooltip, seems to me more to the point.
Now that I've had the chance to play with this a bit more, I do wonder if the button should have the same style as the others (white and round) instead of using the same layout as the Emergency Stop...
Co-authored-by: Pedro Lamas <[email protected]>
Both suggestions sound good to me, I'll implement those later 😉 |
@Martyfree123 Just to clarify - the green in the icon is only because of my fluidd theme. Would you like the icon to be colored (green and red?) accordingly or for it to just be white (or theme colored)? |
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
Closes #729 - Supersedes #736
![image](https://user-images.githubusercontent.com/25269274/177602972-8af34daa-88ff-4de8-a1c8-b9c10b17630e.png)
![image](https://user-images.githubusercontent.com/25269274/177207269-af0fa0b4-d12c-4f6d-ae53-911c9e4316a5.png)
Also swaps the power switch icon with toggle switch icons for more intuitive UX:
![image](https://user-images.githubusercontent.com/25269274/177603085-5ee17c55-433c-4764-8e37-7d2a3be4eec6.png)
![image](https://user-images.githubusercontent.com/25269274/177603098-657cb48a-328d-4809-ac71-08a33f99e9b5.png)
Signed-off-by: Mathis Mensing [email protected]