Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: device power toggle in top navigation #739

Merged
merged 11 commits into from
Jul 6, 2022

Conversation

matmen
Copy link
Member

@matmen matmen commented Jul 4, 2022

Closes #729 - Supersedes #736
image
image

Also swaps the power switch icon with toggle switch icons for more intuitive UX:
image image
image image

Signed-off-by: Mathis Mensing [email protected]

@matmen matmen added the FR - Enhancement New feature or request label Jul 4, 2022
@matmen matmen added this to the 1.19 milestone Jul 4, 2022
pedrolamas
pedrolamas previously approved these changes Jul 4, 2022
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!! 🙂

I've suggested an alternative translation for the tooltip, seems to me more to the point.

Now that I've had the chance to play with this a bit more, I do wonder if the button should have the same style as the others (white and round) instead of using the same layout as the Emergency Stop...

src/locales/en.yaml Outdated Show resolved Hide resolved
Co-authored-by: Pedro Lamas <[email protected]>
@matmen
Copy link
Member Author

matmen commented Jul 5, 2022

Now that I've had the chance to play with this a bit more, I do wonder if the button should have the same style as the others (white and round) instead of using the same layout as the Emergency Stop...

Personally I think it would be nice if it retains the colour matching but maybe uses the standard power icon?

Both suggestions sound good to me, I'll implement those later 😉

@matmen
Copy link
Member Author

matmen commented Jul 5, 2022

Personally I think it would be nice if it retains the colour matching but maybe uses the standard power icon?

@Martyfree123 Just to clarify - the green in the icon is only because of my fluidd theme. Would you like the icon to be colored (green and red?) accordingly or for it to just be white (or theme colored)?

@matmen matmen requested a review from pedrolamas July 6, 2022 16:53
@matmen matmen merged commit ed3e647 into fluidd-core:develop Jul 6, 2022
@matmen matmen deleted the feat/top-nav-power-toggle branch July 6, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants