Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Fit console height to screen size #735

Merged
merged 3 commits into from
Jul 2, 2022
Merged

feat(ui): Fit console height to screen size #735

merged 3 commits into from
Jul 2, 2022

Conversation

kerbilg
Copy link
Member

@kerbilg kerbilg commented Jul 1, 2022

Hello,

this PR includes two commits:

  • automatically adjust the console height to the display height
  • update package.json (only patches, so no changes in the code)

desktop:
Bildschirmfoto 2022-07-01 um 19 11 44

mobile:
Bildschirmfoto 2022-07-01 um 19 12 20

signed off by Kerim Bilgic [email protected]

pedrolamas
pedrolamas approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BastelKlug, this is great!

@pedrolamas pedrolamas requested a review from matmen July 2, 2022 13:49
@pedrolamas pedrolamas added the UI - QoL Improvements to the UI label Jul 2, 2022
@pedrolamas pedrolamas added this to the 1.19 milestone Jul 2, 2022
@matmen matmen changed the title Fit console height to screen size and update packages feat(ui): Fit console height to screen size Jul 2, 2022
@matmen matmen merged commit d749a3a into fluidd-core:develop Jul 2, 2022
@kerbilg kerbilg deleted the console-fix branch August 8, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmen matmen matmen approved these changes

@pedrolamas pedrolamas pedrolamas approved these changes

Assignees
No one assigned
Labels
UI - QoL Improvements to the UI
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@kerbilg @pedrolamas @matmen