fix: AppSlider incorrect state #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas
force-pushed
the
pedrolamas/fix-slider
branch
from
2d58bf0
to
3a3db19
Compare
matmen
approved these changes
May 4, 2022
matmen
pushed a commit
to matmen/fluidd
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Pedro Lamas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue caused by AppSlider.vue changes in 863c0b2
This reverts most of those changes as I came to realize that one can use
v-model.numberto force a bind as number...Though AppSlider value is
number, the rules will also be used for a non-valid number, so I added a+safeguard on OutputFan to ensure a number/NaN is in use.Fixes #653
Signed-off-by: Pedro Lamas [email protected]