Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n-HU): Update Hungarian translation #634

Merged
merged 20 commits into from
Apr 20, 2022
Merged

feat(i18n-HU): Update Hungarian translation #634

merged 20 commits into from
Apr 20, 2022

Conversation

AntoszHUN
Copy link
Contributor

Update gcode captions.

Signed-off-by: AntoszHUN [email protected]

Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to keep the line endings on the file as LF but they have been changed to CRLF...

Whatever editor you are using to make these changes, the line endings must be kept as LF (Unix style) instead of CRLF (Windows style).

src/locales/hu.yaml Outdated Show resolved Hide resolved
src/locales/hu.yaml Outdated Show resolved Hide resolved
src/locales/hu.yaml Outdated Show resolved Hide resolved
src/locales/hu.yaml Outdated Show resolved Hide resolved
@AntoszHUN
Copy link
Contributor Author

You need to keep the line endings on the file as LF but they have been changed to CRLF...

Whatever editor you are using to make these changes, the line endings must be kept as LF (Unix style) instead of CRLF (Windows style).

I'm using Windows 10. I've tried all kinds of programs. What do I do to be good?

@pedrolamas
Copy link
Member

I'm on Windows too!

My advice, use Visual Studio Code and install these 2 extensions:

@AntoszHUN
Copy link
Contributor Author

I fixed the bugs. Can it be good now?

@pedrolamas pedrolamas added the UI - Translations Improvements or additions to translations label Apr 20, 2022
@pedrolamas pedrolamas self-requested a review April 20, 2022 09:36
Signed-off-by: Pedro Lamas <[email protected]>
@pedrolamas
Copy link
Member

I fixed the bugs. Can it be good now?

The line endings were still incorrect, but I fixed that for you on the PR (assuming you don't push more updates here, we should be good to merge it)

pedrolamas
pedrolamas previously approved these changes Apr 20, 2022
@pedrolamas pedrolamas requested a review from matmen April 20, 2022 09:43
@pedrolamas pedrolamas added this to the 1.18 milestone Apr 20, 2022
@AntoszHUN
Copy link
Contributor Author

I fixed the bugs. Can it be good now?

The line endings were still incorrect, but I fixed that for you on the PR (assuming you don't push more updates here, we should be good to merge it)

All right. Thanks! I won't update then.

@matmen
Copy link
Member

matmen commented Apr 20, 2022

ah, my bad, it should be Gcode not G-Code, will fix that

Signed-off-by: Mathis Mensing <[email protected]>
@AntoszHUN
Copy link
Contributor Author

ah, my bad, it should be Gcode not G-Code, will fix that

Why did I have to rewrite it? In English, G-Code means something. The Hungarian free translation of this is G-Code. Code = Kód. Why wasn't it good now? I translated the klipper3d.org website into Hungarian in 2.5 months. Everywhere the G-Code was rewritten into Hungarian G-Kód. No one fixed it because it wasn't a bug.

@matmen
Copy link
Member

matmen commented Apr 20, 2022

From what I've seen so far fluidd's convention here is to stick to the english locale for "Gcode" - as you can see here and here for example. I think it makes sense to stick to this, as I think it's more universal.

@AntoszHUN
Copy link
Contributor Author

The translation does not change its meaning.

@matmen
Copy link
Member

matmen commented Apr 20, 2022

I am aware of that, but fluidd's localization convention is to leave it untranslated. It's untranslated in all the other translations too.

@pedrolamas pedrolamas changed the title Update Hungarian language feat(i18n-HU): Update Hungarian translation Apr 20, 2022
@pedrolamas pedrolamas merged commit db84b02 into fluidd-core:develop Apr 20, 2022
@AntoszHUN
Copy link
Contributor Author

I'm on Windows too!

My advice, use Visual Studio Code and install these 2 extensions:

* [EditorConfig for VS Code](https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig) - this will ensure you use the same formats as we need to

* [i18n Ally](https://marketplace.visualstudio.com/items?itemName=Lokalise.i18n-ally) - helper extension for translations!
  ![image](https://user-images.githubusercontent.com/85504/164196661-0d506438-3251-48a7-bcc6-6a1ddb823e94.png)

I installed the programs. But for the i18N Ally, how can it be made to work? He's not doing anything to me.

@pedrolamas
Copy link
Member

if you open the repo (folder) in Visual Studio, it should just detect the translations!

matmen added a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Signed-off-by: AntoszHUN <[email protected]>
Co-authored-by: Pedro Lamas <[email protected]>
Co-authored-by: Mathis Mensing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI - Translations Improvements or additions to translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants