fix: fully unload dialogs when not in use #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas
added
the
Code - Optimizations
matmen
approved these changes
Apr 13, 2022
matmen
pushed a commit
to matmen/fluidd
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Pedro Lamas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it currently stands, most dialogs are loaded on the Vue object tree but kept hidden until needed, something I believe we actually do not need, so this PR changes that!
Before:
After:
The
UpdatingDialogworks a bit differently, so that one I kept as is.I've also fixed a bug on the
FileNameDialog, where clicking outside the dialog would close it but we wouldn't be able to open it again!Signed-off-by: Pedro Lamas [email protected]