-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fullscreen camera page #609
feat: fullscreen camera page #609
Conversation
Signed-off-by: Mathis Mensing <[email protected]>
How does FPS compare against a simple stream tab, when using higher resolution or higher FPS cameras? Please see my comments on UI performance here: #525 (comment) I think my comments from the full-screen console card may be worth bearing in mind here also: #613 (comment) Could we make this behavior optional via a setting, or introduce an additional button for the original direct camera feed? Personally I will always prefer to have a simple direct stream opened in a tab, and I think many other users will too given that very few people are likely using the hflip/vflip options. I think a good compromise that makes everyone happy might be as follows:
|
I'm streaming my main camera at 1080p@30fps using adaptive MJPEG, and I'm getting a stable 30fps in the full screen view with this. The iframe option gives me around 60fps too. I can only see fps limiting happening on the dashboard and it looks to be because of the notifyStatusUpdate dispatching/handling.
I don't really think this is an uncommon issue - from what I've seen on the Discord a lot of people are having issues with the fullscreen view not taking into account rotation and flipping. The only way for them to solve that issue would be editing the webcam config, which isn't trivial (at least much less than clicking a UI dropdown).
This seems fine to me. Would love to get some input from @pedrolamas (and maybe @Durahl and @PigeonFX too) on this too. |
Sounds good, thanks for confirming!
I suspect the majority (90%?) aren't using those options so they would enjoy the raw full-screen tab, and I definitely agree enough people are using rotation and flip for it to be important to provide for those users too.
Sounds good. Can we have both please! :D Seems like we are in agreement. I can see myself using both a full-screen webcam nav bar item which shows both cameras at once, and also the raw stream URL in a new tab option, depending on what I'm trying to see. |
Signed-off-by: Mathis Mensing <[email protected]>
@matthewlloyd I'm not really happy with all the implementations involving just slapping the camera card onto its own page.. The cameras end up being too small and the button to change cameras causes a global state change to happen, which causes weird UX behavior on the dashboard. From the suggestion (#279 (comment)) I think just showing a single camera at a time (per page) would be fine, what do you think? I've pushed something I've had stashed for the better part of 3 weeks now, but I'm not sure if I'm happy with it lol |
I went back and tried some alternative ways to solve this today, and so far I wasn't happy with any of them (UX wise, my PR included).. If anyone has specific suggestions I'm happy to implement them |
Marking this as ready for review as I haven't received more feedback yet, maybe this is worth being an intermediate solution ;) |
Co-authored-by: Pedro Lamas <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]> Co-authored-by: Pedro Lamas <[email protected]>
Adds a dedicated page for the fullscreen camera feed, solving the following issues:
Currently still opens in a new tab, not sure if this is the appropriate behavior
Tested with (adaptive and streamed) MJPEG sources on:
Closes #542 #279