fix: TouchEvent is not defined on Firefox desktop #601
Conversation
There was a problem hiding this comment.
Sorry, but this doesn't seem right. Swapping the statements for TouchEvents and MouseEvents won't work here, because the order of checks is important (touch events only register on the card header, mouse events on the entire page, so this change breaks the behavior on all browsers).
|
I've gone ahead and fixed this issue (and another one I found) in the above linked PR. Thanks for your effort and reporting this. |
Also, registers the event handlers for the duration of the drag only. The event handler were not removed because the component is not unmounted. Signed-off-by: Maël Kerbiriou <[email protected]>
Piezoid
force-pushed
the
fix-touchevent-firefox
branch
from
3023628
to
953a489
Compare
|
You're right, fixed. I noticed the event handler were not removed because the component is not unmounted. Tested with Firefox and Chrome on mobile and desktop. Edit: Ok, no problem. thanks |
|
Ah, nice. I think your solution is much more elegant and fixes some more issues. I'll close my PR, thanks for the fix 😉 |
|
Sorry I left the tab as a reminder for a while and didn't see your message. I also noticed the access |
Signed-off-by: Maël Kerbiriou <[email protected]>
On Firefox desktop, we get undefined references errors to
window.TouchEventin the console when the color picker is loaded.