Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for moonraker socket connection identification #568

Merged
merged 4 commits into from
Mar 19, 2022

Conversation

matmen
Copy link
Member

@matmen matmen commented Mar 10, 2022

Adds support for moonraker socket connection identification for new features mentioned by @Arksine in the Discord.

@matmen matmen added the FR - Enhancement New feature or request label Mar 10, 2022
@matmen matmen added this to the 1.18 milestone Mar 11, 2022
@matmen matmen modified the milestone: 1.18 Mar 19, 2022
@matmen
Copy link
Member Author

matmen commented Mar 19, 2022

Meant to delay the merge of this until Moonraker made use of this data other than for HTTP-based event subscriptions, but just realized it's already used for logging.

@matmen matmen marked this pull request as ready for review March 19, 2022 14:50
@matmen matmen requested a review from pedrolamas March 19, 2022 14:50
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matmen matmen merged commit 7a6b6d0 into fluidd-core:develop Mar 19, 2022
@matmen matmen deleted the feat/moonraker-identify branch March 19, 2022 15:53
matmen added a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants