feat: show qr-code with api key #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes fluidd-core#411 Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas
force-pushed
the
pedrolamas/411
branch
from
c092c17 to
bb4216c
Compare
pedrolamas
changed the title
matmen
requested changes
Feb 17, 2022
Signed-off-by: Pedro Lamas <[email protected]>
|
@matmen thanks for reviewing, I've updated the PR following up your on comments (also updated the main image on the PR description to show the latest changes) |
eduncan911
approved these changes
Feb 18, 2022
|
Greate work! |
matmen
pushed a commit
to matmen/fluidd
that referenced
this pull request
Jun 27, 2022
* feat: show qr-code with api key Fixes fluidd-core#411 Signed-off-by: Pedro Lamas <[email protected]> * fix: adds white border around qr-code Signed-off-by: Pedro Lamas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411
Adds new dependency to qrcode.vue
Signed-off-by: Pedro Lamas [email protected]