fix: revert ECharts changes previously introduced #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pecirep
approved these changes
Feb 7, 2022
Signed-off-by: Pedro Lamas <[email protected]>
pecirep
force-pushed
the
pedrolamas/revert-chart
branch
from
302df92
to
2a269d4
Compare
matmen
pushed a commit
to matmen/fluidd
that referenced
this pull request
Jun 27, 2022
These were introduced as part of the work for Node 16 support in fluidd-core#482, but we've now come to realize that not only are they not needed, but they are also creating a layout issue on the charts. Signed-off-by: Pedro Lamas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were introduced as part of the work for Node 16 support, but we've now come to realize that not only are they not needed, but they are also creating a layout issue on the charts.
Signed-off-by: Pedro Lamas [email protected]