Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: temperature rate of change #496

Merged
merged 6 commits into from
Feb 17, 2022

Conversation

matmen
Copy link
Member

@matmen matmen commented Jan 30, 2022

This PR adds a Rate of Change column for heater temperatures to the Thermals card, toggleable via a new settings context menu (disabled by default).
The calculated rate of change is based on a rolling average of the last 5 data points to filter out sensor reading fluctuations. Absolute deltas of < 0.05 are filtered out to prevent a constant flipping of the RoC sign when the RoC is ~0.
Discussion is welcome. Closes #409.

image
image

Signed-off-by: Mathis Mensing <[email protected]>
@StuSerious
Copy link
Collaborator

Love this!
Super useful in multi extrusion printing to get the switch times just perfect, and overall a cool metric to monitor and brag about!

@Biorn1950
Copy link
Contributor

Biorn1950 commented Jan 30, 2022

@matmen what do you think to have all the settings icons aligned next to the arrow like that:
Capture d’écran 2022-01-30 à 06 28 06

everything else is ok.

@matmen
Copy link
Member Author

matmen commented Jan 30, 2022

I must have overlooked that. Fixed.
image

Biorn1950
Biorn1950 previously approved these changes Jan 30, 2022
Copy link
Contributor

@Biorn1950 Biorn1950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Feb 4, 2022
@pedrolamas pedrolamas merged commit 30a2628 into fluidd-core:develop Feb 17, 2022
@matmen matmen deleted the feature/rate-of-change branch February 17, 2022 17:29
@matmen matmen added this to the Release: 1.17 milestone Feb 22, 2022
@matmen matmen added the Docs - Needed Docs need to be added for tagged issue label Feb 22, 2022
@matmen
Copy link
Member Author

matmen commented Feb 22, 2022

Screenshot on Thermals Chart needs to be updated, and settings dropdown may need to be documented?

@matmen matmen mentioned this pull request Feb 23, 2022
7 tasks
@NyxCode
Copy link

NyxCode commented Mar 13, 2022

Love this feature - however, I'd like to see this for all thermistors. Especially for a chamber thermistor this would be awesome.

@pedrolamas
Copy link
Member

Love this feature - however, I'd like to see this for all thermistors. Especially for a chamber thermistor this would be awesome.

@NyxCode that has just been added, it's available right now on the develop branch and will be part of the next release! 🙂

matmen added a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Signed-off-by: Mathis Mensing <[email protected]>
Co-authored-by: Pedro Lamas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs - Needed Docs need to be added for tagged issue FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Rate of Change column to Thermals
5 participants