-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: temperature rate of change #496
feat: temperature rate of change #496
Conversation
Signed-off-by: Mathis Mensing <[email protected]>
Love this! |
@matmen what do you think to have all the settings icons aligned next to the arrow like that: everything else is ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Screenshot on Thermals Chart needs to be updated, and settings dropdown may need to be documented? |
Love this feature - however, I'd like to see this for all thermistors. Especially for a chamber thermistor this would be awesome. |
@NyxCode that has just been added, it's available right now on the |
Signed-off-by: Mathis Mensing <[email protected]> Co-authored-by: Pedro Lamas <[email protected]>
This PR adds a Rate of Change column for heater temperatures to the Thermals card, toggleable via a new settings context menu (disabled by default).
The calculated rate of change is based on a rolling average of the last 5 data points to filter out sensor reading fluctuations. Absolute deltas of
< 0.05
are filtered out to prevent a constant flipping of the RoC sign when the RoC is~0
.Discussion is welcome. Closes #409.