-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: directory sorting #492
Conversation
Hi @trapeznikov-ap, thank you for your PR. From what I can see on my own machine, the ".." always appears on top, no matter what file list I'm looking at, so I was just wondering where did you see this behavior broken? |
At me the problem is shown at sorting in descending order by names. Tell me the sort direction and which column are you sorting by? Do you have folders with names that start with an exclamation mark? |
Can you send a screenshot showing this behavior? Are you using cyrillic chars for your filenames and folders? From me, using regular chars it is working as normal when ordering by Name ascending and descending, so ".." is always on top. |
You are correct @trapeznikov-ap , I got a repo of the issue and your fix does mitigate it completely, but I think we can "improve" it a bit, as you should be able to move those 2 new lines outside of the Can you check that please? |
The top directory ".." should always be the first in the list when sorting