Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: make each axis controllable after homing #478

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

Biorn1950
Copy link
Contributor

@Biorn1950 Biorn1950 commented Jan 26, 2022

Give the possibility to move an axis if the others are not homed.

like that:
Capture d’écran 2022-01-26 à 18 15 40
instead of that:
Capture d’écran 2022-01-26 à 18 36 36

Signed-off by Biorn : [email protected]

Give the possibility to move an axis if the other are not homed

Signed-off by Biorn : [email protected]
Copy link
Contributor

@eduncan911 eduncan911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to find time to pull down the source and set it up to check all of this Vue code. Looks good at 2 or 3 glances. ;)

Will wait for @pedrolamas to give a second review as he may be more versed in Vue than I.

@eduncan911 eduncan911 added FR - Change GH - Waiting for Feedback Waiting for the issuer to reply UI - Change All matters related to a significant change in the UI labels Jan 26, 2022
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Biorn1950, it's working great!!

@pedrolamas pedrolamas removed the GH - Waiting for Feedback Waiting for the issuer to reply label Jan 26, 2022
@eduncan911 eduncan911 merged commit d931646 into fluidd-core:develop Jan 26, 2022
@Biorn1950 Biorn1950 deleted the Move-after-homing branch January 27, 2022 01:27
pedrolamas added a commit to pedrolamas/fluidd that referenced this pull request Feb 20, 2022
@matmen matmen added this to the Release: 1.17 milestone Feb 22, 2022
matmen pushed a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Give the possibility to move an axis if the other are not homed

Signed-off by Biorn : [email protected]

Co-authored-by: Eric Duncan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI - Change All matters related to a significant change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants