Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro parameter inputs aren't populated if floats are used. #376

Closed
Dromantor opened this issue Aug 1, 2021 · 0 comments · Fixed by #524
Closed

Macro parameter inputs aren't populated if floats are used. #376

Dromantor opened this issue Aug 1, 2021 · 0 comments · Fixed by #524
Assignees
Labels
GH - Bug Something isn't working

Comments

@Dromantor
Copy link

fluidd version: v1.16.2-0fa3c9b

If you have a macro defined with any decimal/float parameter defaults fluidd doesn't detect those default values correctly. It just leaves those input fields empty (= it displays the parameter name in the input fields [which also is confusing at first, you could think it passes the parameter name itself as a value until you click into the input field]).

Reproduction Steps:

Define any macro with parameters with decimal number defaults.

In my case:
[gcode_macro PA_TOWER_SETUP]
gcode:
{% set S = params.S|default(0.2)|float %} ; start
{% set F = params.F|default(0.02)|float %} ; factor
{% set B = params.B|default(0)|float %} ; band
SET_VELOCITY_LIMIT SQUARE_CORNER_VELOCITY=1 ACCEL=500
TUNING_TOWER COMMAND=SET_PRESSURE_ADVANCE PARAMETER=ADVANCE START={S} FACTOR={F} BAND={B}

Actual Results:

In fluidd the inputs for S and F, which have decimal defaults, are left empty, the B input is correctly populated with 0.

Screenshot(s):

Unbenannt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants