fix(gcodepreview): ignore moves without coordinates #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that some files sliced by Orca Slicer have G0/G1 commands without any X, Y, Z, or E change.
Though I am not sure why these commands exist, the fact is that this introduced a bug on the Gcode Previewer, where these moves would cause extra extrusion markers to apper.
The fix here is to ignore any G0/G1/G2/G3 command that does not include at least one of the necessary coordinates change arguments.
This also includes a minor fix for the previewer code where
retractionswhere incorrectly being checked forextrusions.Before
After