-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make color picker use v-model and propsync #1375
fix: make color picker use v-model and propsync #1375
Conversation
Signed-off-by: Pedro Lamas <[email protected]>
@matmen I know you also have an incoming PR with work on this area, I made it easy to integrate your changes in this one (just by using the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened a PR on your repo that fixes the color settings not applying in the metrics settings, otherwise these changes LGTM
Signed-off-by: Pedro Lamas <[email protected]>
Oops, I forgot to change those |
This PR refactors the
AppIroColorPicker
andAppColorPicker
to use v-model and propsync where possible, thus making the control easier to consume, and fixing the reported issue.Note: following up on what we already do with our custom input controls, changing the value on the text input boxes will not take effect unless Enter is pressed.
Fixes #1372