-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve support for adaptive bedmeshes #1328
Conversation
Signed-off-by: Mathis Mensing <[email protected]>
So far I only performed a quick test on this, but I'm not sure I understand why we need the new Regarding saving an adaptive mesh, though I can't think of a scenario where that would be required, I see no problem in allowing it either, as I think Klipper will not complain if one tried to save it via |
I have now managed to catch up on this and even check the code changes on Klipper side. Functionality wise, I have tested these changes in Fluidd and they worked perfectly, no issues at all! From what I can see, Klipper makes no real distinction between a regular mesh and an adaptive mesh (except this naming convention that brings nothing special), and that is what is troubling me right now as I fail to see what increased value there is in indicating to the user that this is an adaptive mesh, which we are basing only on the mesh name! |
Adaptive bed meshes arent reported in the bed mesh profile list, so they don't show up in the profile list in fluidd. This can be confusing to users, as there's an active bed mesh loaded, but the list doesn't show an active one (or no meshes at all if there's none defined in the config). |
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
Co-authored-by: Pedro Lamas <[email protected]> Signed-off-by: Mathis Mensing <[email protected]>
Improves support for Klipper's new native adaptive bed meshes (Klipper3d/klipper#6461 Klipper3d/klipper#6473)
Shows a "virtual" bed mesh profile in the list and disables the "delete profile" button, temporary (/adaptive) profiles cannot be deleted.
![image](https://private-user-images.githubusercontent.com/25269274/300290905-68f012bb-9162-469d-8bfd-32a5119891eb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MDMxOTgsIm5iZiI6MTczOTkwMjg5OCwicGF0aCI6Ii8yNTI2OTI3NC8zMDAyOTA5MDUtNjhmMDEyYmItOTE2Mi00NjlkLThiZmQtMzJhNTExOTg5MWViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE4VDE4MjEzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUzZjJkY2ZlZmI1YzAwOGFiNGU5YTdjODMyMDk1YjMyMzhlZjdmODBhYjc2MTc4ZDBhMWVlYTgzZGVjYTg4ZGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Ydkbw1J0ORSVQrgzDo6X0Kz-ciNeH5akmOtpZL5C8UI)