Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve support for adaptive bedmeshes #1328

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

matmen
Copy link
Member

@matmen matmen commented Jan 28, 2024

Improves support for Klipper's new native adaptive bed meshes (Klipper3d/klipper#6461 Klipper3d/klipper#6473)

Shows a "virtual" bed mesh profile in the list and disables the "delete profile" button, temporary (/adaptive) profiles cannot be deleted.
image

@matmen matmen added the FR - Enhancement New feature or request label Jan 28, 2024
@matmen matmen added this to the 1.28 milestone Jan 28, 2024
@matmen matmen requested a review from pedrolamas January 28, 2024 20:12
@pedrolamas
Copy link
Member

pedrolamas commented Jan 29, 2024

So far I only performed a quick test on this, but I'm not sure I understand why we need the new BedMeshProfileListEntry without min and max from BedMeshProfile... any specific reason for this new type?

Regarding saving an adaptive mesh, though I can't think of a scenario where that would be required, I see no problem in allowing it either, as I think Klipper will not complain if one tried to save it via BED_MESH_PROFILE SAVE=<name> command.

@pedrolamas
Copy link
Member

I have now managed to catch up on this and even check the code changes on Klipper side.

Functionality wise, I have tested these changes in Fluidd and they worked perfectly, no issues at all!

From what I can see, Klipper makes no real distinction between a regular mesh and an adaptive mesh (except this naming convention that brings nothing special), and that is what is troubling me right now as I fail to see what increased value there is in indicating to the user that this is an adaptive mesh, which we are basing only on the mesh name!

@matmen
Copy link
Member Author

matmen commented Jan 29, 2024

Adaptive bed meshes arent reported in the bed mesh profile list, so they don't show up in the profile list in fluidd. This can be confusing to users, as there's an active bed mesh loaded, but the list doesn't show an active one (or no meshes at all if there's none defined in the config).
Showing the raw profile name and re-enabling the "Save As" button should be fine tho, I just thought a list entry with the name "adaptive" looked better than "adaptive-abcdef".

@matmen matmen requested a review from pedrolamas January 29, 2024 17:27
Co-authored-by: Pedro Lamas <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
@matmen matmen merged commit 447a340 into fluidd-core:develop Jan 29, 2024
4 checks passed
@matmen matmen deleted the feat/adaptive-bedmesh branch January 29, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants