Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language commit history incorrect #1293

Closed
thijstriemstra opened this issue Dec 25, 2023 · 9 comments · Fixed by #1299
Closed

Language commit history incorrect #1293

thijstriemstra opened this issue Dec 25, 2023 · 9 comments · Fixed by #1299
Assignees
Labels
GH - Bug Something isn't working
Milestone

Comments

@thijstriemstra
Copy link
Contributor

thijstriemstra commented Dec 25, 2023

Fluidd Version

1.27.1

Browser

Firefox

Device

Desktop PC

Operating System

Windows

What happened

Language is set to English:

afbeelding

But I'm seeing Dutch in the commit history panel (gisteren and eergisteren):

afbeelding

What did you expect to happen

Honour language setting and ignore browser/os language.

How to reproduce

Use a non-english browser to view commit history.

Additional information

No response

@thijstriemstra thijstriemstra added GH - Bug Something isn't working GH - Evaluation Needed This topic needs to be discussed to evaluate it's aspects and feasability labels Dec 25, 2023
@pedrolamas
Copy link
Member

Hi @thijstriemstra, thanks for opening this issue.

Can you check if changing to another language and then back to English solves the problem?

@thijstriemstra
Copy link
Contributor Author

I'll have to check once moonraker or klipper has an update again, can't access panel without updates.

@thijstriemstra
Copy link
Contributor Author

changing to another language and then back to English solves the problem?

  • changed to german
  • checked (still dutch)
  • changed to english
  • checked (still dutch)

@pedrolamas
Copy link
Member

Can you try opening in an anonymous browser window?

If it shows with no problem on the anonymous window, I recommend that performing a full refresh of Fluidd (clearing the browser cache)

@thijstriemstra
Copy link
Contributor Author

(clearing the browser cache)

I'm doing that everytime already.

Can you try opening in an anonymous browser window?

Yep but will have to wait for klipper/moonraker updates again first, since I just updated 😋

@thijstriemstra
Copy link
Contributor Author

Tested again, and a private firefox window didn't make a difference.

@pedrolamas
Copy link
Member

I might know what is at play here, let me do some checks and I will report back when I can...

@pedrolamas
Copy link
Member

I did a quick test on this and now I recall that we are using the browser locale to format dates & times, so I assume your main browser language is Dutch?

@thijstriemstra
Copy link
Contributor Author

yea it's dutch

@pedrolamas pedrolamas removed the GH - Evaluation Needed This topic needs to be discussed to evaluate it's aspects and feasability label Jan 2, 2024
@pedrolamas pedrolamas added this to the 1.27.2 milestone Jan 2, 2024
@pedrolamas pedrolamas self-assigned this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants