fix: corrects original source attributions #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
vajonam
force-pushed
the
fix/add_atrribution_for_svg
branch
from
8fdf2ce
to
96788e3
Compare
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
|
Many thanks for adding the links to Mainsail. I personally think the "heavily adapted" sounds "bad". I would consider "adapted for fluidd" to be "correct" in this case. just my 2 cents... |
Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add attribution and inspiration for the source circle control was adapted from. This was already in the original PR, making it more obvious by moving out the top.
Signed-off-by: vajonam [email protected]