Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds support for public base path #1207

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: adds support for public base path #1207

merged 1 commit into from
Oct 10, 2023

Conversation

pedrolamas
Copy link
Member

This will allow Fluidd to be build with the --base parameter.

The service worker will still NOT work as the default config expects "/" as base path.

Partial fix for #1206

@pedrolamas pedrolamas added GH - Bug Something isn't working Code - Optimizations Everything that relates to code optimizations! labels Oct 10, 2023
@pedrolamas pedrolamas added this to the 1.26 milestone Oct 10, 2023
@pedrolamas pedrolamas merged commit 7f0886d into fluidd-core:develop Oct 10, 2023
3 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/fix-base-path branch October 10, 2023 16:35
@pedrolamas pedrolamas mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code - Optimizations Everything that relates to code optimizations! GH - Bug Something isn't working
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
1 participant
@pedrolamas