feat: adds HLS camera stream support #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
matmen
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds HLS stream support via hls.js.
To test it, just add a new camera, select "HLS Stream", and set the URL to "https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8"
Using `import Hls from 'hls.js' caused this issue, which I fixed by adding a simple alias to vite.config.js
As hls.js is an extra 370Kb and will be used as an "opt-in" kind of feature, I've made sure that it dynamically imported to keep the bundle size lower.
On a side note, I really dislike how the whole CameraItem.vue is... there is way too much stuff in there and it is becoming quite unmanageable, so once this gets merged, I will attempt to refactor each streamer into separate Vue files.