Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Kinesis Firehose and Kinesis Streams plugins #2485

Closed
PettitWesley opened this issue Aug 22, 2020 · 4 comments
Closed

Core Kinesis Firehose and Kinesis Streams plugins #2485

PettitWesley opened this issue Aug 22, 2020 · 4 comments
Assignees
Labels
AWS Issues with AWS plugins or experienced by users running on AWS

Comments

@PettitWesley
Copy link
Contributor

Currently we have go plugins:

Ideally, these plugins should be re-written in C and contributed to the core of fluent bit. This would fix known throughput issues with the go plugins: #2159

I will do this eventually, though I am not sure the core versions will necessarily fully replace the go plugins. The Kinesis streams go plugin will soon have KPL aggregation support- that feature might be harder to port to C- the core versions of these plugins might be simpler.

@PettitWesley
Copy link
Contributor Author

I've started prototyping a core Kinesis Firehose plugin, though its not clear when I will have time to finish it.

@PettitWesley PettitWesley self-assigned this Aug 22, 2020
@PettitWesley PettitWesley added the AWS Issues with AWS plugins or experienced by users running on AWS label Aug 22, 2020
@zihengCat
Copy link
Contributor

Fluent Bit AWS Kinesis output plugins rely on AWS Go SDK, it's not so easy to be re-written in C.
Maybe ports AWS Go SDK Kinesis to C ?
https://github.com/aws/amazon-kinesis-streams-for-fluent-bit/blob/dc9767ccd86f2b0484fa4bb614d5ac24d0908690/kinesis/kinesis.go#L432

@PettitWesley
Copy link
Contributor Author

I already did that; wrote an AWS SDK in C for Fluent Bit earlier this year: https://github.com/fluent/fluent-bit/tree/master/src/aws

A Kinesis Firehose C plugin will be released in 1.6: https://github.com/fluent/fluent-bit/tree/kinesis-firehose-high-throughput

The firehose plugin and kinesis plugin code are very similar. Long term I want to rewrite that firehose code into a more generic library that can support both kinesis streams and firehose.

@PettitWesley
Copy link
Contributor Author

New output kinesis_firehose was launched a while ago, and in 1.7.0 today kinesis_streams was added!

We now have core versions of all of the official AWS go plugins!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWS Issues with AWS plugins or experienced by users running on AWS
Projects
None yet
Development

No branches or pull requests

2 participants