Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filesystem storage on Windows #1694

Closed
fujimotos opened this issue Oct 30, 2019 · 9 comments
Closed

Add support for filesystem storage on Windows #1694

fujimotos opened this issue Oct 30, 2019 · 9 comments
Assignees

Comments

@fujimotos
Copy link
Member

fujimotos commented Oct 30, 2019

Task Summary

Implement file-chunk storage support using Win32 API.

The goal is to make the following configuration "just work" on Windows platforms.

[SERVICE]
    flush                     1
    log_Level                 info
    storage.path              C:\FluentBit\Storage\
    storage.sync              normal
    storage.checksum          off
    storage.backlog.mem_limit 5M

Memo

The biggest blockage is the lack of mmap() on Windows.
We need to find some way to share file data among multiple processes.

@fujimotos
Copy link
Member Author

For those who interested in this feature: I started to tinker with
the code to implement this feature today.

@zlymeda
Copy link
Contributor

zlymeda commented Jun 19, 2020

any updates on this, pls?

@fujimotos
Copy link
Member Author

This task is being tracked by #2738. Hopefully we can make it
into the next v1.7.0 release...

@fujimotos
Copy link
Member Author

Update: The support PR is submitted to #2810 (and fluent/chunkio/pull/59).

@qingling128
Copy link
Collaborator

Any plan for a release that will include this change?

@fujimotos
Copy link
Member Author

@qingling128 All the related patches are already in master.

I expect it to be included in the next v1.7.0 release (due February).

@qingling128
Copy link
Collaborator

I see. I guess because it's a new feature, it will not be backported to 1.6.*, right?

@fujimotos
Copy link
Member Author

I see. I guess because it's a new feature, it will not be backported to 1.6.*, right?

@qingling128 Right. Since fluent/chunkio/pull/59 contains 1000+ LoC changes,
I don't expect it to be backported.

FWIW, this is the milestone page for the next v1.7 release:
https://github.com/fluent/fluent-bit/milestone/10

@qingling128
Copy link
Collaborator

Thanks for the info. That's very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants