Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(worker): add worker.remove [fixes NET-354 NET-376] #1499

Merged
merged 14 commits into from
Mar 14, 2023
Merged

feat(worker): add worker.remove [fixes NET-354 NET-376] #1499

merged 14 commits into from
Mar 14, 2023

Conversation

justprosh
Copy link
Member

No description provided.

@justprosh justprosh changed the title feat(worker): add worker.remove feat(worker): add worker.remove [NET-354 NET-376] Mar 7, 2023
@linear
Copy link

linear bot commented Mar 7, 2023

NET-354 Scope Keypair -> Worker Keypair

Worker keypair should be possible to generate from deal_id (and, i.e., from init_peer_id for compatibility with current spells' state)

NET-376 Implement Worker.remove

Remove all services, spells and aliases on that worker

@justprosh justprosh marked this pull request as ready for review March 7, 2023 12:02
@justprosh justprosh requested review from kmd-fl, folex and gurinderu and removed request for kmd-fl March 7, 2023 12:03
@justprosh justprosh mentioned this pull request Mar 7, 2023
Merged
kmd-fl
kmd-fl reviewed Mar 8, 2023
View reviewed changes
crates/particle-node-tests/tests/spells.rs Show resolved Hide resolved
sorcerer/src/sorcerer.rs Outdated Show resolved Hide resolved
sorcerer/src/worker_builins.rs Show resolved Hide resolved
sorcerer/src/spells.rs Outdated Show resolved Hide resolved
folex
folex reviewed Mar 10, 2023
View reviewed changes
spell-storage/src/storage.rs Outdated Show resolved Hide resolved
@justprosh justprosh requested a review from folex March 14, 2023 10:17
folex
folex reviewed Mar 14, 2023
View reviewed changes
spell-storage/Cargo.toml Outdated Show resolved Hide resolved
folex
folex reviewed Mar 14, 2023
View reviewed changes
spell-storage/src/storage.rs Outdated Show resolved Hide resolved
@justprosh justprosh enabled auto-merge (squash) March 14, 2023 12:47
@folex folex disabled auto-merge March 14, 2023 13:21
@folex folex changed the title feat(worker): add worker.remove [NET-354 NET-376] feat(worker): add worker.remove [fixes NET-354 NET-376] Mar 14, 2023
@folex folex merged commit 97f552f into master Mar 14, 2023
@folex folex deleted the remove_worker branch March 14, 2023 13:21
@fluencebot fluencebot mentioned this pull request Mar 14, 2023
Merged
@fluencebot fluencebot mentioned this pull request Jun 22, 2023
Merged
@fluencebot fluencebot mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmd-fl kmd-fl kmd-fl approved these changes

@folex folex folex approved these changes

@gurinderu gurinderu Awaiting requested review from gurinderu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justprosh @folex @kmd-fl