-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add worker.create and worker.get_peer_id #1475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folex
approved these changes
Feb 20, 2023
kmd-fl
reviewed
Feb 21, 2023
sorcerer/src/spells.rs
Outdated
let is_worker_creator = init_peer_id == worker_creator; | ||
let is_worker = init_peer_id == worker_id; | ||
|
||
if !is_spell_owner && !is_worker_creator && !is_worker { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the manager of the peer be able to remove the spell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right
kmd-fl
reviewed
Feb 21, 2023
kmd-fl
approved these changes
Feb 21, 2023
Co-authored-by: Maria Kuklina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scope.get_peer_id
is removedworker.create
accepts optionaldeal_id
argumentdeal_id
is omitted,init_peer_id
is used to generate workerspell.install
execution on host peer id implicitly callworker.create
withoutdeal_id
argworker.create
returns error if worker fordeal_id
existsworker.get_peer_id
accepts optionaldeal_id
argument, return worker_id or throws an errorNew worker flow for deals: