fix(spells): do not run spells with passed (ended) Clock trigger #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folex
changed the title
folex
approved these changes
Feb 10, 2023
justprosh
approved these changes
Feb 10, 2023
| self.spell_event_bus_api | ||
| .subscribe(spell_id.clone(), config.clone()) | ||
| .await?; | ||
| } else { | ||
| log::warn!("Spell {spell_id} is not rescheduled since its config is either not found or not reschedulable"); |
There was a problem hiding this comment.
I think it should be info, not warn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now all spells will be rerun after the node restart, even the ones that ended before restarting.
So the new rule is: the spell won't be restarted if in its trigger config
end_at <= nowor it's a one-shot spell that started in the past.Not sure about the following events:
end_atwas added, then the node was shut down untilend_at, so the spell was never executed.These events don't seem to be very relevant though.