Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spells): correct interpretation of end_sec field [NET-346] #1431

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Jan 26, 2023

To be with correspondence with the docs:

Will not trigger after that timestamp

@kmd-fl kmd-fl requested a review from folex January 26, 2023 08:58
@linear
Copy link

linear bot commented Jan 26, 2023

NET-346 Fix spell-event-bus use of `end_sec` field to abrupt spell execution correctly

Right now we are checking that end_sec < now, but we should check end_sec < now + period , so that the spell won't be executed after end_sec at all.

@kmd-fl kmd-fl changed the title fix(spells:) correct interpretation of end_sec field [NET-346] fix(spells): correct interpretation of end_sec field [NET-346] Jan 26, 2023
@kmd-fl kmd-fl enabled auto-merge (squash) January 26, 2023 11:16
@kmd-fl kmd-fl merged commit 2b018de into master Jan 26, 2023
@kmd-fl kmd-fl deleted the fix-spell-schedule-end-sec branch January 26, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants