-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(worker_pool)!: Shift service creation to the worker pool [Fixes NET-716] #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurinderu
force-pushed
the
feature/net-716
branch
from
January 29, 2024 10:26
32b6061
to
bbcd361
Compare
why? |
kmd-fl
reviewed
Feb 2, 2024
justprosh
reviewed
Feb 2, 2024
justprosh
reviewed
Feb 2, 2024
justprosh
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request contains the shifting of the service creation to the worker pool. Also, it has a separation of ParticleAppServices into the root & worker contexts.
Motivation
Related Issue(s)
NET-716
Proposed Changes
Introduced PeerScope enum describes the current execution scope
ParticleAppServices - have separate structures for the root scope & worker scopes.
Workers can use a WorkerId only, doesn't work for the root worker.
PeerScope used everywhere instead of worker_id.
Screenshots (if applicable)
[Add any relevant screenshots or animated GIFs to showcase the changes.]
Checklist
Reviewer Checklist