feat(spells): store last trigger by trigger
key in KV [NET-511]
#1728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Store only the last trigger event from nox (connection pool and timer trigger events) in spell KV by
trigger
key.Motivation
Previously, trigger events were stored in the Spell Mailbox, but it can be used by other spells and clients to pass data to the spell, and it became hard to distinguish trigger events from other events. We decided to store only the last trigger separately, so spell developers can easily find the event that triggered spell execution by adding
trigger
arg to spell signature:Related Issue(s)
[Cite any related issues or feature requests here, using GitHub issue links.]
Proposed Changes
trigger
keyScreenshots (if applicable)
[Add any relevant screenshots or animated GIFs to showcase the changes.]
Additional Notes
[Provide any additional information or context that may be helpful for the reviewer.]
Checklist
Reviewer Checklist