Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): added versions endpoint #1700

Merged
merged 11 commits into from
Jul 18, 2023
Merged

feat(http): added versions endpoint #1700

merged 11 commits into from
Jul 18, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Jul 12, 2023

Description

Added versions HTTP endpoint

Motivation

Right now, people have to dig through nox's logs, which is hard.

Proposed Changes

Added additional HTTP endpoint which returns json with the format:

{
    "node": "0.13.1",
    "avm": "0.41.0",
    "spell": "0.5.15",
    "aqua_ipfs": "0.5.14",
    "trust_graph": "0.4.7",
    "registry": "0.8.7",
    "decider": "0.4.16"
}

Additional Notes

The marine version wasn't added because this information is inaccessible for now.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear
Copy link

linear bot commented Jul 12, 2023

NET-444 Add /versions HTTP endpoint to rust-peer

Should return version of rust-peer and AVM as json

@gurinderu gurinderu marked this pull request as ready for review July 12, 2023 15:06
@gurinderu gurinderu requested review from kmd-fl, justprosh and folex and removed request for kmd-fl and justprosh July 12, 2023 15:06
@gurinderu gurinderu added the e2e Run e2e workflow label Jul 13, 2023
nox/src/http.rs Outdated Show resolved Hide resolved
folex

This comment was marked as resolved.

nox/src/http.rs Show resolved Hide resolved
nox/src/http.rs Outdated Show resolved Hide resolved
nox/src/http.rs Outdated Show resolved Hide resolved
nox/src/http.rs Outdated Show resolved Hide resolved
nox/src/http.rs Outdated Show resolved Hide resolved
@folex folex self-requested a review July 14, 2023 15:53
nox/src/http.rs Outdated Show resolved Hide resolved
nox/src/http.rs Show resolved Hide resolved
@folex folex enabled auto-merge (squash) July 17, 2023 18:09
@folex folex disabled auto-merge July 18, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants