feat: use indexer directly [JS-842] #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when using Promise.all that inits and manipulates the same config
shamsartem
changed the title
MixailE
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Let's split this file into smaller ones
There was a problem hiding this comment.
if you don't mind I will think about doing that in a separate PR. I think splitting the code in multiple files doesn't solve any concrete issues, more of a matter of a taste thing, though I could be wrong and I agree this file is pretty big already. On the other hand it still seems ok to work with and as a bonus doesn't require you to jump between many files when working with commitments, which is pretty convenient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.