Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoveltySlice w/ MFCCs: Mel frequency range correct? #86

Closed
weefuzzy opened this issue Jan 28, 2022 · 3 comments · Fixed by #87
Closed

NoveltySlice w/ MFCCs: Mel frequency range correct? #86

weefuzzy opened this issue Jan 28, 2022 · 3 comments · Fixed by #87
Assignees
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@weefuzzy
Copy link
Member

@g-roma

In NoveltySliceClient, mMelBands is initialized with a frequency range of 20Hz to 2kHz. Is this right, or did you mean 20kHz?

mMelBands.init(20, 2000, 40, get<kFFT>().frameSize(), sampleRate(),
get<kFFT>().winSize());

@weefuzzy weefuzzy added help wanted Extra attention is needed question Further information is requested labels Jan 28, 2022
@weefuzzy weefuzzy self-assigned this Jan 28, 2022
@g-roma
Copy link
Member

g-roma commented Jan 28, 2022

Probably a typo, although generally change in lower frequencies will probably be more interesting. 5k is a common choice for music, and in some cases I have seen improvements in focusing on environmental sound below 1k, but on top of my head I don't remember having a reason for using 2k here.

@weefuzzy
Copy link
Member Author

Cheers for the quick reply. I'd be inclined to change it in that case. Is there stuff that depends on the current behaviour of NoveltySlice with MFCCs that's likely to break if / when this happens? (e.g. do your does any of your stuff for FCM2 depend on the current behaviour?)

@g-roma
Copy link
Member

g-roma commented Jan 28, 2022

Certainly not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants