Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect compatibility issue with Node 14 #556

Closed
bjmvercelli opened this issue Sep 27, 2024 · 5 comments
Closed

Effect compatibility issue with Node 14 #556

bjmvercelli opened this issue Sep 27, 2024 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@bjmvercelli
Copy link

Describe the bug
Support for Node 14 broke with #553 since Effect uses nullish coalescing assignment operator (??=), which is available for Node >= 15 (reference: https://node.green/#ES2021-features-Logical-Assignment-----basic-support)

image

Versions (please complete the following information):

  • OS: Linux
  • Serverless Framework Version:3.39.0
  • Plugin Version: 7.2.3
@bjmvercelli bjmvercelli added the bug Something isn't working label Sep 27, 2024
@floydspace
Copy link
Owner

yeah, it is expected, we dropped the v14 support, it's time to move on,
I can look at it if I can quickly implement transpilation to node 14,
but for now you can use older plugin version v1.53.0

@bjmvercelli
Copy link
Author

yeah, it is expected, we dropped the v14 support, it's time to move on, I can look at it if I can quickly implement transpilation to node 14, but for now you can use older plugin version v1.53.0

Agree 100%, its time to move on haha.
I don't think that's necessary to implement transpilation to Node 14 but we could update supported runtimes on README, what you think?

@floydspace
Copy link
Owner

yes makes sense

@floydspace floydspace added documentation Improvements or additions to documentation and removed bug Something isn't working labels Sep 27, 2024
@bjmvercelli
Copy link
Author

Appreciate the great work. Let me know if you want me to open PR ;)

@floydspace
Copy link
Owner

@bjmvercelli just fyi added it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants