feat: added disableIncremental option to completely turn off incremental compilation #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floydspace
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Hi @gurushida , thanks for your contribution, I think it's good to have it let me merge.
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: preventing a memory leak
When used in combination with serverless-offline on a typescript codebase of about 200.000 lines of code, my colleagues and I have observed a memory leak that caused in our case about 500Mb to be consumed on each code change triggering a recompilation (as described in #98). After some experiments with serverless-esbuild's code, it turned out that totally disabling incremental compilation made the problem disappear. Since esbuild is extremely fast, giving up incremental compilation did not affect our development speed, which is why we want to propose to add an option to do that.