Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore function definition image #215

Merged
merged 4 commits into from
Oct 24, 2021
Merged

feat: ignore function definition image #215

merged 4 commits into from
Oct 24, 2021

Conversation

samchungy
Copy link
Collaborator

Resolves #212

Ignores functions which have container images provided. Containerised images should provide their own build instructions so we should be safe to ignore them.

src/index.ts Show resolved Hide resolved
Copy link
Owner

@floydspace floydspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. Merging it.

@floydspace floydspace changed the base branch from master to develop October 24, 2021 12:28
@floydspace floydspace merged commit 4d4a53f into floydspace:develop Oct 24, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using AWS ECR image with TypeScript
2 participants