feat(zip): make bestzip an off-by-default option #187
Conversation
bestzip preserves file timestamps, which causes function zips to be different after every esbuild. Because there are scenarios where native js zipping is unacceptably slower than native system zip, the option to use it is preserved as an option. Fixes: #186
|
FYI @vamche -- I'm proposing a change here that would require a small config change to preserve your use of system |
|
Hey @troyready, thanks for the PR. Looks good to me. I have suggested a similar approach in the past but we didn't take it forward because of some concerns. Here is the related thread/comment #150 (comment). Could you please check with @olup? |
|
Thanks for the background, that is helpful. FWIW, in regards to that exact comment: we wouldn't be able to use To olup's comments, I'm fine either way. I do like the simplicity of just having a single implementation (without another config option), but it's going to be a matter of opinion on whether that's the right tradeoff. |
There was a problem hiding this comment.
@troyready Looks good to me as well. thanks that documented it. as soon @olup approves as it concerns his comment, I merge it
|
Well, I am partial to a simple implementation. And for me, the main thing is to have reliable timestamps - a problem that I did not know about before. However because the native zip seems to be an important feature for some users, and as we started supporting it, I am fine with an optional parameter that lets one opt-in native zipping (reliable timestamps should stay the default). So I am good with this PR. |
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
bestzip preserves file timestamps, which causes function zips to be different after every esbuild.
Because there are scenarios where native js zipping is unacceptably slower than native system zip, the option to use it is preserved as an option.
Fixes: #186