Do we need to copy all files before zipping?

[jeromeheissler]

I've worked locally inside the zip function to trace the duration of each step of the pipe:

serverless-esbuild/src/utils.ts

Lines 91 to 103 in 7dc3b64

	await pipe(
	// create the random temporary folder
	mkdirpTask(tempDirPath),
	// copy all required files from origin path to (sometimes modified) target path
	TE.chain(() => copyFilesTask(filesPathList)),
	// prepare zip folder
	TE.chain(() => mkdirpTask(path.dirname(zipPath))),
	// zip the temporary directory
	TE.chain(() => (useNativeZip ? bestZipTask : nodeZipTask)),
	// delete the temporary folder
	TE.chain(() => removeTask(tempDirPath)),
	taskEitherToPromise
	);

With a zip concurrency to 1 on my Macbook Pro 16" 2019, the copy step duration is between 2s and 3s, and the zip step between 3 and 4s :

Or the bestzip source can take in parameter a list of files directly. Instead of making this:

const bestZipTask = taskFromPromise(() => bestzip({ source: '*', destination: zipPath, cwd: tempDirPath }));

We can reference all files directly:

const bestZipTask = taskFromPromise(() =>
  bestzip({ source: filesPathList.map((c) => c.localPath).join(' '), destination: zipPath, cwd: tempDirPath })
);

Maybe we can reduce /2 the zipping time by removing copy step.

I don't know if there is an impact on native zip