Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local flow-bin package on OSX #240

Closed
ssenchenko opened this issue Apr 27, 2018 · 5 comments
Closed

Use local flow-bin package on OSX #240

ssenchenko opened this issue Apr 27, 2018 · 5 comments

Comments

@ssenchenko
Copy link

I know you had similar issue (#69) and closed it. However, I have the same problem on OSX.
My configuration:

  • flowtype version 0.8.1 (recently installed)
  • "flow.useNPMPackagedFlow": true,
  • "flow.pathToFlow": "${workspaceFolder}/client/web/node_modules/.bin/flow"

I keep on getting the error from VSCode:
[Flow] Cannot find flow in PATH. Try to install it by npm install flow-bin -g

I don't think that it's a good idea to install flow globally or add project specific node_modules/.bin/flow to PATH.
@orta
Copy link
Contributor

orta commented Apr 27, 2018

This feels like a bug with getting the flow binary to me

@budarin
Copy link

budarin commented Jun 17, 2018

I have the error on Windows too.
It only accepts full path which is not sutable for any :(

@martpie
Copy link

martpie commented Jun 26, 2018 •
edited
Loading

I have the same problem, here's my config:

"javascript.validate.enable": false,
"flow.useNPMPackagedFlow": true,
"flow.pathToFlow": "${rootPath}/website/node_modules/.bin/flow",
// "flow.pathToFlow": "${workspaceFolder}/website/node_modules/.bin/flow",
// does not work either

@aligfl
Copy link

aligfl commented Sep 28, 2018

Seeing the same issue. even though i have i have the path set:
"flow.pathToFlow": "${workspaceFolder}/node_modules/flow-bin/flow-osx-v0.81.0/flow",

I'm still getting:
[Flow] Cannot find flow in PATH. Try to install it by npm install flow-bin -g

Mayank1791989 added a commit to Mayank1791989/flow-for-vscode that referenced this issue Feb 16, 2019
@Mayank1791989
feat(lsp): add multi config & multi-root workspace support
00a4697 
Client (closes flow#302, flow#304, flow#253, flow#228, flow#201, flow#195, flow#189, flow#184, flow#165, flow#81)
- add multi flowconfig support
- add vscode multi-root workspace support
- client is now lazily created if flowconfig found
- fix document selector.

New implementation will handle following cases
- Single workspace with multiple flowconfig
- Multiple workspace with multiple flowconfig

Get Flow-Bin
- improve|fix logic to find flow-bin (fixes flow#282, flow#240, flow#209)
- fix flow bundled with plugin not working
  issue: we are using .bin/flow but vscode never includes .bin in plugin package
- add logs while finding flow-bin to debug issues
- plugin now doesn't check for node (closes flow#290)
- pathToFlow: value is normalized and .cmd is added so same value can
be used for linux, osx & win

Error handling (closes flow#200)
- [feat] improve error handling.
- [feat] Show action in errors so that user can recover from error
  without restarting vscode

Commands
- [feat] Add commands
  - Toggle coverage
  - Show client status
  - Restart Client
  - Log Client Debug Info
  - Show output channel

Status Widget
Include more info in status widget to help user know what this plugin is using
- [feat] include flow version
- [feat] add flow info section in widget tooltip which includes
  - path to .flowconfig
  - flow version
  - path to "flow" binary

Settings
- flow.coverageSeverity to control type coverage diagnostic severity
- flow.useBundledFlow control use of flow bundled with this plugin
- flow.trace.server log communication between vscode and flow lsp
- flow.logLevel control log level of plugin logs
Mayank1791989 added a commit to Mayank1791989/flow-for-vscode that referenced this issue Feb 18, 2019
@Mayank1791989
feat(lsp): add multi config & multi-root workspace support
b5be657 
Client (closes flow#302, flow#308, flow#253, flow#228, flow#201, flow#195, flow#189, flow#184, flow#165, flow#81)
- add multi flowconfig support
- add vscode multi-root workspace support
- client is now lazily created if flowconfig found
- fix document selector.

New implementation will handle following cases
- Single workspace with multiple flowconfig
- Multiple workspace with multiple flowconfig

Get Flow-Bin
- improve|fix logic to find flow-bin (fixes flow#282, flow#240, flow#209)
- fix flow bundled with plugin not working
  issue: we are using .bin/flow but vscode never includes .bin in plugin package
- add logs while finding flow-bin to debug issues
- plugin now doesn't check for node (closes flow#290)
- pathToFlow: value is normalized and .cmd is added so same value can
be used for linux, osx & win

Error handling (closes flow#200)
- [feat] improve error handling.
- [feat] Show action in errors so that user can recover from error
  without restarting vscode

Commands
- [feat] Add commands
  - Toggle coverage
  - Show client status
  - Restart Client
  - Log Client Debug Info
  - Show output channel

Status Widget
Include more info in status widget to help user know what this plugin is using
- [feat] include flow version
- [feat] add flow info section in widget tooltip which includes
  - path to .flowconfig
  - flow version
  - path to "flow" binary

Settings
- flow.coverageSeverity to control type coverage diagnostic severity
- flow.useBundledFlow control use of flow bundled with this plugin
- flow.trace.server log communication between vscode and flow lsp
- flow.logLevel control log level of plugin logs
@Mayank1791989 Mayank1791989 mentioned this issue Feb 18, 2019
Merged
@Mayank1791989
Copy link
Contributor

Fixed in v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@orta @martpie @Mayank1791989 @budarin @ssenchenko @aligfl