Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete Options in flowR repl #730

Merged
merged 11 commits into from
Mar 15, 2024
Merged

Autocomplete Options in flowR repl #730

merged 11 commits into from
Mar 15, 2024

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Mar 15, 2024

No description provided.

@Ellpeck Ellpeck linked an issue Mar 15, 2024 that may be closed by this pull request
Autocomplete Options in flowR repl #257
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.35135% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 70.71%. Comparing base (48570e8) to head (b68701e).

Files Patch % Lines
src/cli/repl/core.ts 35.29% 11 Missing ⚠️
src/cli/common/scripts-info.ts 44.44% 5 Missing ⚠️
src/cli/repl/commands/commands.ts 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   70.83%   70.71%   -0.13%     
==========================================
  Files         217      217              
  Lines        7076     7105      +29     
  Branches     1096     1103       +7     
==========================================
+ Hits         5012     5024      +12     
- Misses       1771     1788      +17     
  Partials      293      293

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ellpeck Ellpeck requested a review from EagleoutIce March 15, 2024 13:03
@Ellpeck Ellpeck marked this pull request as ready for review March 15, 2024 13:03
EagleoutIce
EagleoutIce reviewed Mar 15, 2024
View reviewed changes
@Ellpeck Ellpeck requested a review from EagleoutIce March 15, 2024 15:50
EagleoutIce
EagleoutIce reviewed Mar 15, 2024
View reviewed changes
Ellpeck and others added 3 commits March 15, 2024 16:54
@Ellpeck @EagleoutIce
ugh
110bc1d 
im literally just using a dumb commit message to spite you

Co-authored-by: Florian Sihler <[email protected]>
@Ellpeck
refactor: move file protocol to to a constant
3d59096
@Ellpeck
Merge remote-tracking branch 'origin/257-autocomplete-options-in-flow…
b68701e 
…r-repl-1' into 257-autocomplete-options-in-flowr-repl-1
@Ellpeck Ellpeck requested a review from EagleoutIce March 15, 2024 16:12
@Ellpeck
Copy link
Member Author

Ellpeck commented Mar 15, 2024

i dare you to reject again

@EagleoutIce EagleoutIce merged commit 2010237 into main Mar 15, 2024
21 checks passed
@EagleoutIce EagleoutIce deleted the 257-autocomplete-options-in-flowr-repl-1 branch March 15, 2024 16:17
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EagleoutIce EagleoutIce EagleoutIce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocomplete Options in flowR repl
2 participants
@Ellpeck @EagleoutIce