Drop xmlparsedata and replace it with getParseData #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
- Coverage 71.58% 71.37% -0.22%
==========================================
Files 219 218 -1
Lines 7145 7082 -63
Branches 1103 1092 -11
==========================================
- Hits 5115 5055 -60
+ Misses 1739 1737 -2
+ Partials 291 290 -1 ☔ View full report in Codecov by Sentry. |
|
Some notes from @EagleoutIce:
|
…drop-xmlparsedata
|
oh fucking hell |
|
This is pretty much review-ready, except for the type safety of |
EagleoutIce
reviewed
Feb 23, 2024
EagleoutIce
approved these changes
Feb 23, 2024
EagleoutIce
added a commit
that referenced
this pull request
Feb 24, 2024
* refactor: construct children collection once * lint-fix: specify return type of isRoot directly * refactor: further performance & style improvements * refactor: helpless panic * refactor: another iteration of urgh * Revert "refactor: another iteration of urgh" This reverts commit e0bf428. * refactor: swapping tries for gods sake * Revert "refactor: swapping tries for gods sake" This reverts commit b77cebe. * Reapply "refactor: another iteration of urgh" This reverts commit 63c19a2. * refactor(wip): interim mental breakdown * refactor: at least... happy tests? * refactor: lock jsonlite options * refactor(cfg-test): remove fake test * refactor: try manual conversion, is worse * Revert "refactor: try manual conversion, is worse" This reverts commit 578c64e. * refactor: simplify json conversion * refactor: several minor performance tunes :3 * refactor: ensure the executor dies directly (and gracefully) * refactor: dynamic `flowr_get` compile * refactor: fine-tune cmp retrieval * refactor: reduce size of json produce, defer obj map to flowR * doc(test): remove dead jsdoc comment * refactor: clean up tmp logfiles * lint-fix: handle minor linter problems * refactor: wordly clean-up * feat: jsonlite begone! * refactor: further improve print-out-performance * refactor: always compile seems to be faster! * refactor: use build for benchmark run * refactor: switch back to `sort` * feat(tests): cover for optional xmlparsedata availability --------- Co-authored-by: Florian Sihler <[email protected]>
|
This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.