Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move commands.yml to resources folder #3

Open
lukespragg opened this issue Aug 13, 2014 · 3 comments
Open

Move commands.yml to resources folder #3

lukespragg opened this issue Aug 13, 2014 · 3 comments
Assignees

Comments

@lukespragg
Copy link
Member

This file should not be in the root directory. Just making this issue for myself.
https://github.com/flow/examples/blob/master/commands/commands.yml

@lukespragg lukespragg self-assigned this Aug 13, 2014
@Wolf480pl
Copy link
Contributor

Actually, it might be the right place for it. It's not a resource that should come within the jar. It's a runtime configuration file, that is autogenerated if absent, and sometimes altered by the application. The one placed in the repository is an example of manual modification of the file to customize the structure of the command tree by a user of the application.

@lukespragg
Copy link
Member Author

Ah, well, it could still go under resources, even if not included in the jar?

@Wolf480pl
Copy link
Contributor

That would require explicitly excluding it from resources in pom, and either changing its path in the code to src/main/resources/command.yml (not very clean) or running the app with src/main/resources as the working directory (even worse).
Alternatively, we can create a directory config and move it there, and change the path in code to config/commands.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants