Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License: MIT and LGPLv3 #223

Closed
xyproto opened this issue Dec 12, 2019 · 4 comments
Closed

License: MIT and LGPLv3 #223

xyproto opened this issue Dec 12, 2019 · 4 comments

Comments

@xyproto
Copy link
Contributor

xyproto commented Dec 12, 2019

Hello Florian Schlachter,

First of all, thanks for creating pongo2! I'm using it in Algernon, and it's working really well. It has good performance and is a solid package.

After running a "license analyzer" tool called FOSSA (link), I am told that Algernon is not only using the MIT license (or MIT compatible licenses) but also LGPLv3. This has consequences for how a statically compiled executable can be distributed. I see that pongo2 also uses an MIT license, like Algernon, so perhaps this is also in your interest.

pongo2 uses juju/errors, which is licensed under the LGPLv3 license. This has consequences for how a statically compiled Algernon binary can be distributed.

This is a feature request to make pongo2 fully compatible with the MIT license.

Best regards,
Alexander F. Rødseth

@xyproto xyproto changed the title License: MIT and GPLv3 License: MIT and LGPLv3 Dec 12, 2019
@jclc
Copy link
Contributor

jclc commented May 29, 2020

Hello, I am also disappointed that a dependency effectively taints this library as GPL. On a cursory glance the imported error package isn't used extensively however. Does the new errors package in the standard library provide the necessary functionality, so that juju/errors can be replaced?

@flosch
Copy link
Owner

flosch commented May 29, 2020

Feel free to submit a PR which removes the dependency. I'd be glad to see something which only uses the standard library. Any help is highly appreciated.

@jclc
Copy link
Contributor

jclc commented May 29, 2020

Turns out it was just a matter of 2 search-and-replaces.

@flosch
Copy link
Owner

flosch commented May 29, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants