Skip to content

Commit

Permalink
chore(bump dependencies)
Browse files Browse the repository at this point in the history
  • Loading branch information
nmccready committed Oct 10, 2016
1 parent d4acefa commit 2d8c319
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 14 deletions.
28 changes: 14 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,22 @@
"author": "Florian Reiterer <[email protected]>",
"license": "ISC",
"dependencies": {
"acorn": "^2.6.4",
"convert-source-map": "^1.1.1",
"css": "^2.2.1",
"detect-newline": "^1.0.3",
"graceful-fs": "^4.1.2",
"source-map": "^0.5.3",
"strip-bom": "^2.0.0",
"through2": "^2.0.0",
"vinyl": "^1.0.0"
"acorn": "4.X",
"convert-source-map": "1.X",
"css": "2.X",
"detect-newline": "2.X",
"graceful-fs": "4.X",
"source-map": "0.X",
"strip-bom": "3.X",

This comment has been minimized.

Copy link
@shinnn

shinnn Oct 10, 2016

Contributor

@nmccready I should have commented it before v1.7.0 release, but I just found that this commit actually required major version bump.

strip-bom v3.0.0 doesn't support Node 0.x, that means, this update introduces a breaking change — drop Node 0.x support — to gulp-sourcemap.

As a transitory measure, you should:

  1. Unpublish v1.7.0
  2. Downgrade strip-bom to ^2.0.0
  3. Publish v1.7.1

This comment has been minimized.

Copy link
@nmccready

nmccready Oct 10, 2016

Author Collaborator

Well of-course there is a prob ;) . Should we really unpublish? Is this not dangerous? Should we delete the dit tags as well?

This comment has been minimized.

Copy link
@nmccready

nmccready Oct 10, 2016

Author Collaborator

@zacronos @floridoo well poop

This comment has been minimized.

Copy link
@shinnn

shinnn Oct 10, 2016

Contributor

Should we really unpublish? Is this not dangerous?

Yes, all the projects running on Node 0.x and depending gulp-sourcemap v1.x is currently broken because of this change.

Should we delete the dit tags as well?

You meant git tag? I don't think so. Only unpublishing v1.7.0 from npm is enough.

This comment has been minimized.

Copy link
@nmccready

nmccready Oct 10, 2016

Author Collaborator

I'll push 1.7.1 first and then un-publish 1.7.0 from npm.

This comment has been minimized.

Copy link
@nmccready

nmccready Oct 10, 2016

Author Collaborator

@shinnn to confirm 2.X of strip-bom is good as well right?

This comment has been minimized.

Copy link
@shinnn

shinnn Oct 10, 2016

Contributor

@nmccready

to confirm 2.X of strip-bom is good as well right?

Yes.

This comment has been minimized.

Copy link
@nmccready

nmccready Oct 10, 2016

Author Collaborator

Resolved 1.7.1 was published and 1.7.0 unpublishd

"through2": "2.X",
"vinyl": "1.X"
},
"devDependencies": {
"jshint": "^2.8.0",
"tape": "^4.2.0",
"istanbul": "^0.3.21",
"faucet": "0.0.1",
"coveralls": "^2.11.4"
"jshint": "2.X",
"tape": "4.X",
"istanbul": "0.X",
"faucet": "0.0.X",
"coveralls": "2.X"
},
"files": [
"index.js"
Expand Down
2 changes: 2 additions & 0 deletions test/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,8 @@ test('init: should not throw when source file for sourceContent not found', func
.write(file);
});

// vinyl 2.X breaks this spec, exactly sure why but it is due to this commit
// https://github.com/gulpjs/vinyl/commit/ece4abf212c83aa3e2613c57a4a0fe96171d5755
test('init: should use unix style paths in sourcemap', function(t) {
var file = makeFile();
file.base = file.cwd;
Expand Down

0 comments on commit 2d8c319

Please sign in to comment.