Rdoc enhancements

[BurdetteLamar]

Enhancements in json.rb:

• Added JSON types.
• More examples for JSON.parse and JSON.generate.
• Examples for all JSON additions.
• Example custom JSON addition.

Enhancements in common.rb:

• More examples for JSON.generate, its options, and its exceptions.
• More examples for JSON.parse, its options, and its exceptions.
• Example for JSON.pretty_generate.

Not enhanced: JSON.restore, JSON.dump, JSON.load, JSON.recurse_proc.

If preferred, I can put up a PR with just json.rb.
Also if preferred, I can put up piecemeal PRs for common.rb.

[BurdetteLamar]

@flori, I think this is ready for review.

[BurdetteLamar]

@flori, you are not interested in this?

[marcandre]

👍 This is a fabulous upgrade to the docs 🙇‍♂️

Here's my initial review

[BurdetteLamar]

@marcandre, if nothing more, I'll go ahead and merge this.
And thanks for your careful review.

[marcandre]

@marcandre, if nothing more, I'll go ahead and merge this.

There are 6 unresolved comments.

And thanks for your careful review.

My pleasure. Great PR

[BurdetteLamar]

@marcandre, Oops, I don't have merge access here (though I'm a member of ruby-committers).
Do you know who should look at this?

[marcandre]

@marcandre, Oops, I don't have merge access here (though I'm a member of ruby-committers).
Do you know who should look at this?

Same here 😅

@hsbt will merge when ready

[marcandre]

@BurdetteLamar would you please check the remaining 6 items?

[hsbt]

I'm going to merge after approving by @marcandre

[BurdetteLamar]

Thanks, much, to both of you!

I'm going to merge after approving by @marcandre

[marcandre]

Great work! Should be "squash and merged" into a single commit.

[marcandre]

@hsbt: LGTM, except that 4 commits should be squash-merged.

[BurdetteLamar]

@hsbt, will you be merging this? I don't want to do anything more until this PR is resolved.

[hsbt]

Merged.

@BurdetteLamar You should avoid to use RDoc enhancements each commits. There is no information for other people from its commit message. You write the description/how/why of your work on commits.

[marcandre]

@BurdetteLamar You should avoid to use RDoc enhancements each commits. There is no information for other people. You write the description/how/why of your work on commits.

@hsbt why didn't you squash-merge these commits? I find the fact that you haven't written any positive message or thank you about this 600+ lines PR and say "There is no information for other people" a bit ironic. There are 500 new lines of information... Yes, ideally these would have been squashed but Github gives you the possibility to do it yourself. Why didn't you?

[hsbt]

Why didn't you?

It's my mistake because this repository didn't set squash-merge as default.

I find the fact that you haven't written any positive message

Sorry, I have no enough english skill. But I also got it from you. I always feel blame, enforce and rush about fix, resolve, review and release each OSS repository in holidays and weekend. I'm tired about this.

[hsbt]

say "There is no information for other people" a bit ironic. There are 500 new lines of information...

I said it for commit message, not for this patch. I thanks to this contribute.

[marcandre]

But I also got it from you. I always feel blame, enforce and rush about fix, resolve, review and release each OSS repository in holidays and weekend. I'm tired about this.

I'm sorry you feel this way. I am not aware of my comments that make you rush about anything. Could you please point out which of my comments made you feel rushed to do something?

[BurdetteLamar]

@marcandre, maybe best just let @hsbt rest. Past doesn't matter. Let's just concern ourselves with the future?